search

prayag17 / Blink

Modern Desktop Jellyfin Client made with Tauri and React :atom_symbol: [WIP]
GNU General Public License v3.0
687 stars 20 forks source link

Increase and decrease volume using scrollwheel #333

Closed pypp closed 1 month ago

pypp commented 3 months ago

Add the ability to increase and decrease the volume using the mouse wheel. resolves #312

prayag17 commented 3 months ago

Thanks for your work but I will hold PRs for now

pypp commented 3 months ago

no problem.

prayag17 commented 3 months ago

You can now fix the merge conflict

pypp commented 3 months ago

I get the following error when trying to connect to server 

Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons: 1. You might have mismatching versions of React and the renderer (such as React DOM) 2. You might be breaking the Rules of Hooks 3. You might have more than one copy of React in the same app See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
prayag17 commented 3 months ago

Ig that issue is cause by useApiInContext I have used as the api context in tanstack router would update instantly like it should have. I will take a look at it

prayag17 commented 1 month ago

Hey @pypp, you can now rebase you PR. I will merge them as soon as you rebase

pypp commented 1 month ago

rebased.

prayag17 commented 1 month ago

Thanks @pypp