praydog / AutomataMP

NieR: Automata Multiplayer Mod
MIT License
94 stars 10 forks source link

Connect Bugfixes/Additions + Minor Redesign #2

Closed lzardy closed 1 year ago

lzardy commented 1 year ago
praydog commented 1 year ago

Looks good. Not sure if I'm a fan of pointing the defaults away from my master server (at least for the client, I can understand it for the others). It is currently running, and I had planned to keep the server running for as long as I kept an interest in this project.

I only bring it up because IMO the releases on GitHub should have some defaults set up for the end user so they can quickly discover existing servers. Unless you can get it to read from a config file to set the default master server, then the binaries themselves could get rid of that information, and I could just put it in a config file in the release zips.

A side note: can you commit something to your branch again? I just added a workflow for building PRs but it won't let me retroactively build. I just want to make sure this PR will build on Actions.

lzardy commented 1 year ago

My bad, initially meant to keep the original master server. Added back to server.json.