prb28 / vscode-amiga-assembly

Amiga Assembly extension for Visual Studio Code
GNU General Public License v3.0
178 stars 12 forks source link

Improve include path completions #187

Closed grahambates closed 2 years ago

grahambates commented 2 years ago

The current implementation appears to be based on the incorrect assumptions that:

We don't currently limit the scope of symbols by tracking which files are being included where. We just treat all symbols as global and accessible from every source file. I've applied the same approach here, adding an includeDirs symbol map to M68kDefinitionHandler.

Similarly we don't really know which source files are assembled directly vs which are includes. The simplest option is therefore to make paths relative to the workspace root dir, with the assumption that all entrypoints will live there.

Other fixes and enhancements include:

Possible future enhancements: