prb28 / vscode-amiga-assembly

Amiga Assembly extension for Visual Studio Code
GNU General Public License v3.0
178 stars 12 forks source link

Unable to Download Binaries #211

Closed timcal1968 closed 2 years ago

timcal1968 commented 2 years ago

I've tried this extension on Windows 11 and also with Mac OS, and with both versions it will not download the binaries. It tries to start then pops up with an error message:

The "streams" argument must be specified.

Edit: After a lot of playing around, the problem appears to be with the latest version of VSC 1.66 as I've just tried a few older versions of VSC which seem to be fine.

Kind regards, Tim

prb28 commented 2 years ago

You're right, there something wrong with the latest vscode. I'm debugging...

prb28 commented 2 years ago

Relates to https://github.com/microsoft/vscode-file-downloader/issues/31 And https://github.com/microsoft/vscode/issues/144962

prb28 commented 2 years ago

As a workaround on windows, but should be similar on other platforms.

Download the binaries:

Unzip it (as an example in: "c:/mybinaries"). You should have the file c:/mybinaries/fs-uae.exe

Download the example project

Unzip it (as an example here: c:/myproject)

Add file 'c:/myproject/.vscode/settings.json' with:

{
    "amiga-assembly.binDir": "c:/mybinaries"
}

And it should be good to go.

timcal1968 commented 2 years ago

Thanks for taking the time to look into it! Once I realised the problem was specific to the latest version of VSC, I just left the older version installed as I managed to download the binaries that way. I’m guessing it won’t try and download them again now that I have them if I accidentally upgrade?

Kind regards, Tim.

Get Outlook for iOShttps://aka.ms/o0ukef


From: prb28 @.> Sent: Saturday, April 2, 2022 11:24:04 AM To: prb28/vscode-amiga-assembly @.> Cc: Tim Caldwell @.>; Author @.> Subject: Re: [prb28/vscode-amiga-assembly] Unable to Download Binaries (Issue #211)

As a workaround on windows, but should be similar on other platforms.

Download the binaries:

Unzip it (as an example in: "c:/mybinaries"). You should have the file c:/mybinaries/fs-uae.exe

Download the example project

Unzip it (as an example here: c:/myproject)

Add file 'c:/myproject/.vscode/settings.json' with:

{ "amiga-assembly.binDir": "c:/mybinaries" }

And it should be good to go.

— Reply to this email directly, view it on GitHubhttps://github.com/prb28/vscode-amiga-assembly/issues/211#issuecomment-1086609825, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYQJCHYE4Y5T6X3D7HDFFDLVDAN4JANCNFSM5SIKK7XQ. You are receiving this because you authored the thread.Message ID: @.***>

prb28 commented 2 years ago

If you download a new version of the extension the binaries will be updated, and the bug will still be there. But I won't release anything unless I've a solution for this issue. That would bring too much trouble.

timcal1968 commented 2 years ago

Thanks for clarifying the situation. I’ll just stick with an older version of VSC for the time being!

Kind regards, Tim

Get Outlook for iOShttps://aka.ms/o0ukef


From: prb28 @.> Sent: Saturday, April 2, 2022 1:09:35 PM To: prb28/vscode-amiga-assembly @.> Cc: Tim Caldwell @.>; Author @.> Subject: Re: [prb28/vscode-amiga-assembly] Unable to Download Binaries (Issue #211)

If you download a new version of the extension the binaries will be updated, and the bug will still be there. But I won't release anything unless I've a solution for this issue. That would bring too much trouble.

— Reply to this email directly, view it on GitHubhttps://github.com/prb28/vscode-amiga-assembly/issues/211#issuecomment-1086626297, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYQJCH7L44DLHOYUAUIAKR3VDA2H7ANCNFSM5SIKK7XQ. You are receiving this because you authored the thread.Message ID: @.***>

prb28 commented 2 years ago

Fix for the download extension, please install this vsix extension to fix this bug. file-downloader-1.0.12.zip It's a workaround until the official release of this extension.

timcal1968 commented 2 years ago

Awesome, many thanks for looking into the problem and sorting so quickly!

prb28 commented 2 years ago

Fixed in pre-release 1.3.2 -> future release 1.4