search

prb28 / vscode-amiga-assembly

Amiga Assembly extension for Visual Studio Code
GNU General Public License v3.0
178 stars 12 forks source link

option "--monitor=right" ignored after update from 1.6.0 to 1.8.0 #258

Open cobour opened 1 year ago

cobour commented 1 year ago

I used the extension v1.6.0 with these options in launch.json:

            "--fullscreen=1",
            "--monitor=right"

The fullscreen-option is still working, but the monitor-option is ignored (due to new fork of fs-uae?).

Issue found on macOS 13.2.1 using VSC 1.76.1 (and extension 1.8.0).

prb28 commented 1 year ago

should work according to : https://github.com/FrodeSolheim/fs-uae/blob/15a51e33916f87b4d74510ad99ed7297f5f3f18a/docs/options/monitor @grahambates what do you think about this issue?

grahambates commented 1 year ago

My guess is that it's not yet implemented in FS-UAE 4.x, which the new fork is based on. This is a pre-release version and may still be missing some features. I'll try it out on the official build to confirm.

If this (or any other missing feature) is a show-stopper, we could look at porting the Barto debugger implementation to 3.X but I'm guessing this will be a lot more effort. I was hoping to avoid this in order to keep the patches for FS-UAE and WinUAE consistent. It also would prevent us taking advantage of the profiler tools, as this relies on internal data structures only present in 4.2+.

cobour commented 1 year ago

In my opinion this is NOT a show-stopper, it is just a bit annoying. I now use the window mode again for the launchers and wait for a newer version that supports the monitor option again correctly. Thanks for your amazing work on this extension! I love to use it...

prb28 commented 1 year ago

I agree, it's better to wait a stable 4 release and do not create a 3 back port. The old versions of the extension are still accessible.

grahambates commented 1 year ago

I can confirm that the issue is present in the non-patched FS-UAE 4.x.