search

prb28 / vscode-amiga-assembly

Amiga Assembly extension for Visual Studio Code
GNU General Public License v3.0
178 stars 12 forks source link

No documentation for DCB directive #308

Closed neildavis closed 2 months ago

neildavis commented 2 months ago

Firstly, thanks for this amazing extension which I'm really enjoying using to learn 68K/Amiga asm.

I found a problem in the automatic documentation (when you hover over an instruction and the documentation pops up). The DCB directive is not supported. e.g:

        SECTION Data,BSS_C 

Bitplanes:
        DCB.B   (352*32*4)/8
        DC.B    0     ; only here for example

Hover over DC.B and the docs for DC pop up from here

Hover over DCB.B and nothing happens.

This is because there is no DCB.md in /docs/directives. There is a DBC.md which actually docs DCB but with the wrong title. This is also reflected in the TOC

This issue is also in m68k-instructions-documentation for which I raised this pull request

I would raise a similar PR here but I'm assuming this repo is built to include m68k-instructions-documentation somehow, so I'll leave that to the maintainer(s).

prb28 commented 2 months ago

Thanks for PR, You're right about this mistake.

prb28 commented 2 months ago

fixed in the 1.8.11 pre-release.