search

prbutler / EZProxy_IP_Blacklist

EZProxy IP address blacklist for the EZProxy community.
52 stars 15 forks source link

Added new IPs and referrer #2

Closed jswelker closed 6 years ago

jswelker commented 6 years ago

Hi,

I just discovered this project and would like to contribute. At the University of Central Missouri, I have been maintaining my own blacklist for a few years. I have a few dozen IPs and another referrer host to add. I also put together a simple spreadsheet to help dedupe my list from yours and generate the directives. You can take that or leave it.

prbutler commented 6 years ago

Thanks for contributing, this is great! Let me give them a review before I merge. I know I saw at least 1 IP belonging to a university and as a general rule I try not to include those in the blacklist, but encourage to reach out to other institutions and report abuse.

prbutler commented 6 years ago

I brought your edits down to my local copy, merged them with my list of new IPs, removed the IPs below that belong to other universities, then added the new additions to the master files, de-duped, and committed the changes to the master branch. I am new to Git so there may likely be an easier method to make these changes, but this worked OK for me this time. Thanks again for your contribution! to the project

West China University of Medical Sciences 222.196.134.198

University of Texas at El Paso 129.108.148.23 129.108.148.36

Washington State University 134.121.181.214

University of Missouri 198.209.66.1

Tianjin University 202.113.11.150

Shanghai University 202.120.118.140

Capital University of Medical Sciences 202.204.188.173

moorereason commented 6 years ago

@prbutler, First, thanks for maintaining this project. I work at a small university that benefits from your labors!

My suggestion for the future would be to merge contributions in such a way that you don't lose the attribution in the commit logs (either have the author clean up the PR or you clean it up locally). That way they are listed as a contributor to the project, which is a small but important reward for open collaboration.

jswelker commented 6 years ago

Thanks for letting me contribute. I will post more in the future. I've already got some more just in the few days since I sent that last round.

On Mon, Mar 26, 2018 at 11:36 AM, Cameron Moore notifications@github.com wrote:

@prbutler https://github.com/prbutler, First, thanks for maintaining this project. I work at a small university that benefits from your labors!

My suggestion for the future would be to merge contributions in such a way that you don't lose the attribution in the commit logs (either have the author clean up the PR or you clean it up locally). That way they are listed as a contributor to the project, which is a small but important reward for open collaboration.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/prbutler/EZProxy_IP_Blacklist/pull/2#issuecomment-376230109, or mute the thread https://github.com/notifications/unsubscribe-auth/ADlTanOgr4-TeFfTKX53VNA8W58RzymIks5tiRkfgaJpZM4S3KcI .