Inconsistency with ci and local with skipping inexistant hooks

[lorenzwalthert]

A hook that is skipped on pre-commit.ci due to a config entry like this

ci:
    skip: [hook-name-that-does-not-exist]

that is not listed in the config errors on pre-commit.ci, but not on local commit. Example: https://results.pre-commit.ci/run/github/233107318/1650301987.rrehOSvfS-Oq8NHiA2kmGw

I suggest to either:

• ignore hooks that don't exist when considering which to skip
• early check on pre-commit run locally if all hooks in skip are actully listed in the config file and if not, error.

[asottile]

pre-commit ci has an entirely separate parser and it's not parsed by pre-commit (intentionally so the tool is not coupled) -- the validator lives at https://github.com/pre-commit-ci/pre-commit-ci-config and is installable as a pre-commit hook

[lorenzwalthert]

So basically everyone who uses pre-commit.ci has to have this hook... I see where you are coming from but does not look ideal to me. Thanks for the answer anyways, I followed your advice.

[asottile]

they don't have to, but it is available

[lorenzwalthert]

Yes they don't have too, but then it's possible that pre-commit passes locally and not on CI due to an invalid config, which is undesirable. To avoid that, you need the hook. Like the pre-commit parts are validated locally, but the CI parts that are specified in the same file are not.