Signed-off-by / DCO line

[tykeal]

I'm always having to fix the auto update PRs because my projects all require a Signed-off-by (aka DCO) line. For some reason the DCO probot always flags it as valid, but I've got a check that does some "magic" to make pre-commit commit message validation work and gitlint always fails the check.

[asottile]

you'll need to provide more details, it's unclear what you're asking for but it sounds like this is a gitlint feature request?

[tykeal]

No, it's not feature request for gitlint itself. I'm asking for a way to configure the CI bot to add a Signed-off-by footer in the commit messages that it produces. They fail validation that gitlint is doing for me.

[asottile]

you'll need to show more information I still have no idea what you're talking about

[tykeal]

Here's what I end up having to do when I get an auto-update PR from the bot tykeal/homeassistant-rental-control#123

Note the footer of the commit message:

Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>

This is done automatically for you when you issue a '-s' to git commit

My personal repositories as well as literally 100% of every other open source (and non-open) repository I work with all have hard requirements on this DCO line existing. The meaning behind it can be found here: https://developercertificate.org/

[asottile]

the autoupdate commit message is customizable -- feel free to add your DCO to it https://pre-commit.ci/#configuration-autoupdate_commit_msg

[asottile]

a bot itself cannot DCO -- the commits are signed though which is why probot is ok with it -- your tooling is the issue here I suspect since it doesn't recognize signed commits

[tykeal]

the autoupdate commit message is customizable -- feel free to add your DCO to it https://pre-commit.ci/#configuration-autoupdate_commit_msg

I have that set, all it does is modify the commit subject line. None of the rest of the commit message.

[asottile]

    autoupdate_commit_msg: |
        subject here

        Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>

seems to work for me?

[tykeal]

Hmm... I'll give it a try. I was honestly expecting that when I set it that it wouldn't add in the the updated modules information. I sort of expect that it will still end up adding the update module information into the commit thereby breaking this in a different way since SBO is supposed to be a footer.

[asottile]

rather than assuming just try it ! otherwise you're wasting both of our times :P