search

pre-commit-ci / issues

public issues for https://pre-commit.ci
16 stars 3 forks source link

Support GitHub merge queues #170

Closed pokey closed 1 year ago

pokey commented 1 year ago

GitHub has a feature in public beta called merge queues. In order for a PR to advance, checks must be triggered for PRs in the merge queue. These checks don't seem to be triggering for pre-commit CI.

See here for possibly helpful information

asottile commented 1 year ago

this should be pretty easy -- unfortunately it'll request a new permission from every app 🙃

I'll set it up as a read-only check -- will need to play around with the check name since I assume it has to match the one from the pull request and branch protection (even though it's not a pr run)

pokey commented 1 year ago

Yes I think life will be much easier all around if it's just the same name. Probably not too unjustified, as although it's not triggered by the PR trigger, it's still running for a PR 🤷‍♂️

asottile commented 1 year ago

alrighty -- this should be live!

pokey commented 1 year ago

awesome thanks!