search

pre-commit-ci / issues

public issues for https://pre-commit.ci
17 stars 4 forks source link

badge / latest link do not handle default branch names with slashes in them #19

Closed bastienboutonnet closed 3 years ago

bastienboutonnet commented 3 years ago

Both in the pre-commit ci web app and in my readme it seems like the badge is not resolving or so

Screenshot 2020-11-14 at 13 40 58

and https://github.com/bastienboutonnet/sheetwork/blob/chore/add_precommit_ci_badge/README.md

Not sure if it's a me issue but thought I'd post it here.

asottile commented 3 years ago

oops looks like this is a microbug in the web routes -- your default branch contains a slash and so it's not matching the url segment

your code is correct, you should be able to leave it and I'll adjust the routing bits

asottile commented 3 years ago

should be fixed now -- thanks for the report!

[![pre-commit.ci status](https://results.pre-commit.ci/badge/github/bastienboutonnet/sheetwork/dev/nicolas_jaar.svg)](https://results.pre-commit.ci/latest/github/bastienboutonnet/sheetwork/dev/nicolas_jaar)

pre-commit.ci status

asottile commented 3 years ago

(note that I didn't change the markdown, I just put it in the comment so it was clear what I was rendering below)

bastienboutonnet commented 3 years ago

Awesome! It works indeed :) Thanks for looking into it @asottile