search

pre-commit-ci / issues

public issues for https://pre-commit.ci
16 stars 3 forks source link

Update rustc from 1.72.0 to 1.74.0 #211

Closed Freed-Wu closed 2 months ago

Freed-Wu commented 2 months ago 
    => error
    [INFO] Installing environment for https://github.com/Decodetalkers/neocmakelsp.
    [INFO] Once installed this environment will be reused.
    [INFO] This may take a few minutes...
    An unexpected error has occurred: CalledProcessError: command: ('/opt/rust/cargo/bin/cargo', 'install', '--bins', '--root', '/pc/clone/pXeerYyLR4iooDgupss8Jw/rustenv-system', '--path', '.')
    return code: 101
    stdout: (none)
    stderr:
          Installing neocmakelsp v0.6.23 (/pc/clone/pXeerYyLR4iooDgupss8Jw)
            Updating crates.io index
        error: failed to compile `neocmakelsp v0.6.23 (/pc/clone/pXeerYyLR4iooDgupss8Jw)`, intermediate artifacts can be found at `/pc/clone/pXeerYyLR4iooDgupss8Jw/target`.
        To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

        Caused by:
          package `clap v4.5.4` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.72.0
          Either upgrade to rustc 1.74 or newer, or use
          cargo update -p clap@4.5.4 --precise ver
          where `ver` is the latest version of `clap` supporting rustc 1.72.0
asottile commented 2 months ago

you can always select language_version if you need a specific rust -- if you want to move this forward for everyone though the repository for this lives at https://github.com/pre-commit-ci/runner-image

Freed-Wu commented 2 months ago

if you want to move this forward for everyone though the repository

So this issue should go to https://github.com/pre-commit-ci/runner-image ?

asottile commented 2 months ago

I was encouraging you to send a pr!

Freed-Wu commented 2 months ago

Seems to only change thin line:

https://github.com/pre-commit-ci/runner-image/blob/b71d47a6720b82a9241d20a7a9e0b0c90dafbd59/Dockerfile#L121

asottile commented 2 months ago

yep! should be that simple