search

pre-commit-ci / issues

public issues for https://pre-commit.ci
17 stars 4 forks source link

Add shellcheck command to support shell-lint hook #27

Closed danyeaw closed 3 years ago

danyeaw commented 3 years ago

Checks using the shell-lint pre-commit hook are failing because pre-commit-ci doesn't have the shellcheck command available: https://results.pre-commit.ci/run/github/235448/1606152698.vuViAVHoRQ-LIGY84k5kQg

The same check is passing on GitHub Actions: https://github.com/gaphor/gaphor/pull/521/checks?check_run_id=1443504111

asottile commented 3 years ago

Use https://github.com/shellcheck-py/shellcheck-py

asottile commented 3 years ago

pre-commi.ci won't be installing ad-hoc system tools -- language: system / language: script is the escape hatch for pre-commit

danyeaw commented 3 years ago

@asottile Thanks, I didn't know about shellcheck-py, I'll give that a spin :+1: