Closed AleksaC closed 3 years ago
hmm yeah looks like the blank local
repo is missing the remote -- we clear the remote url for security reasons on the main repository but it shouldn't be cleared for the local
repos -- I can get a fix for that
as for rust, it just hasn't been added yet -- you can submit a pull request at https://github.com/pre-commit-ci/runner-image
here's the difference between actual pre-commit: https://github.com/pre-commit/pre-commit/blob/92ce2dcbc375831bab244507e8072a834b761946/pre_commit/store.py#L208 -- I'll adjust pre-commit.ci to not undo this!
ok I've put in a patch to fix the remote issue, it will go out with the next image update! I'll update here once that is shipped
(note: that'll probably be monday as I'm waiting for a podman
release)
Thanks for the quick response and fix! I'll try adding rust support to the image.
this should be deployed now -- thanks again for the issue!
The error is caused by the hooks like this:
Here is the run with these hooks disabled. Here's the run with the hook above enabled. Since
go vet
works, the issue is probably with additional dependencies.I also tested it locally using the following script, based on the one in https://github.com/pre-commit-ci/issues/issues/29#issuecomment-739325539
However there is no error during the installation:
Btw it seems that rust toolchain isn't part of the runner image. Is that intentional? Since there aren't already issues about that I see why adding it might have low priority.