Closed kolibril13 closed 3 years ago
if the contributor force pushes their changes they won't have a problem (it will reformat their stuff)
that said, I'm currently in the process making this workflow possible:
autofix_prs: false
pre-commit.ci autofix
commentthis is now implemented -- you can do just as I said above !
Idea
At the moment, pre-commit.ci changes are directly committed to a branch: To give more control to the user, It might be nice to have an optional button in GitHub called for example "Apply pre-commit changes" , similar to the "Ready for review", or "Update branch" button.
Motivation
Here is a possible situation where this could be useful and avoid confusion (e.g. assuming that pr-commit includes black formatting).
With the new button, the code formatting could only be applied at the end of the pull request review process, and there won't be any probably unexpected changes on the branch by the pr-commit.ci bot.
But also without this button
pr-commit.ci
is already a great feature, especially for auto-formatting the code after applying code changes from the online code suggestion on GitHub.