search

pre-commit-ci / issues

public issues for https://pre-commit.ci
17 stars 4 forks source link

timeout for just adding badge #66

Closed Borda closed 3 years ago

Borda commented 3 years ago

Hello, great took! I have an n00b question, I thought that the pre-commit is running differentiable so checking only on changed files... We just enabled the bot on the Kornia repo, but it is failing even for just adding a badge to the readme... what are we missing? See the filing build https://results.pre-commit.ci/run/github/145693916/1622450657.0xCbY4mtSsamARASH9vPtQ

cc: @edgarriba

asottile commented 3 years ago

hi @Borda looking into this -- I made some suggestions in this PR but let me see if I can get it under time! https://github.com/kornia/kornia/pull/1038

this repository takes 20+ minutes to run on my laptop as it is which is probably not a good developer experience either way!

edgarriba commented 3 years ago

@asottile what machine do you have ? never seen that much time :0 - Suggestions are welcomed in that side too

asottile commented 3 years ago

will send a PR! yapf takes nearly a minute on this file alone: test/augmentation/test_augmentation.py

asottile commented 3 years ago

for context, here's the two PRs:

asottile commented 3 years ago

should be good to go now that kornia/kornia#1052 is merged 🎉