pre-commit-ci / issues

public issues for https://pre-commit.ci
17 stars 3 forks source link

mypy types not installed despite --install-types #69

Closed sebhmg closed 3 years ago

sebhmg commented 3 years ago

mypy fails on pre-commit.ci with error: Library stubs not installed for "toml" However mypy is configured to run with options ["--install-types", "--non-interactive"] that are supposed to install the missing types. This does work when running pre-commit inside a github workflow.

See error below: image

asottile commented 3 years ago

--install-types is not supported and pre-commit.ci does not allow access to the network at runtime

the correct way to fix this is additional_dependencies: [types-toml] or if you want a hammer I created types-all to restore backwards compatibility with old typeshed

sebhmg commented 3 years ago

additional_dependencies: [types-toml] just works. Thank you!