search

pre-commit / pre-commit-hooks

Some out-of-the-box hooks for pre-commit
MIT License
5.34k stars 708 forks source link

Add check for illegal Widnows names #1031

Closed ericfrederich closed 6 months ago

ericfrederich commented 7 months ago

Fixes #589

ericfrederich commented 7 months ago

Took advice from #590 and created a new PR ... sorry for delay

ericfrederich commented 7 months ago

Tests added, let me know if that's what you had in mind.

thetillhoff commented 4 months ago

Any plans on releasing a new version soon with this check included?

Just read about it on the Webpage, tried to add it, but it wasn't found. Then checked the dates, and the last release of pre-commit was before this PR was merged...

asottile commented 4 months ago

you're confused?

thetillhoff commented 4 months ago

Am I? This PR adds the check-illegal-windows-names hook, and was merged on April 16th. The last released version of this repo (https://github.com/pre-commit/pre-commit-hooks/releases/tag/v4.6.0) was released on April 6th.

Is there a plan to create a new release that includes the check-illegal-windows-names hook? Or am I misunderstanding something?

EDIT: And I came across it while reading through https://github.com/pre-commit/pre-commit-hooks where said hook is already listed.

asottile commented 4 months ago

have you read the pre-commit docs?

thetillhoff commented 4 months ago

Probably not the part you have in mind. You are welcome to point me to what you want me to read.