Open github-learning-lab[bot] opened 3 years ago
The first method to submit your query is via a Pull Request. Using a Pull request has several advantages:
However this workflow is bit more involved than just directly committing to the default branch for the purposes of this course.
To submit this query via Pull Request, you can follow the following workflow:
git checkout main
git pull
git checkout -b step-3
git add .
git commit -a -m "First Query"
git push -u origin step-3
This method is simpler. You won't have to juggle between branches, rebase onto the default branch, or create Pull Requests. However, merging directly to the default branch is not a good practice when you are contributing to a shared code base, so if you choose this method, please don't take this bad habit home with you!
To submit this query via a direct commit to the default branch, you can follow this workflow:
git add .
git commit -m "Any message here - why not step 3"
git push origin main
Wait for your work to be checked, and for the results to appear as a comment below. The checks shouldn't take more than 5 minutes.
If the checks are successful, the course will close this issue and create a comment pointing you to the next step. If the checks are unsuccessful, the course will comment on your latest commit with more information, so that you can fix your query and try again.
To track the execution of the query checker, you can follow along in the Actions panel if you like.
ok
Step 3: Finding calls to the jQuery
$
functionYou will now run a simple CodeQL query, to understand its basic concepts and get familiar with your IDE.
:keyboard: Activity: Run a CodeQL query
Edit the file
calls-to-dollar.ql
with the following contents:Don't copy / paste this code, but instead type it slowly. You will see the CodeQL auto-complete suggestions in your IDE as you type.
from
and the first letters ofCallExpr
, the IDE will propose a list of available classes from the CodeQL library for JavaScript. This is a good way to discover what classes are available to represent standard patterns in the source code.where dollarCall.
the IDE will propose a list of available predicates that you can call on the variabledollarCall
.getCalleeName()
to narrow down the list.CallExpr
in the CodeQL JavaScript library.=
operator to assert that two values are equal.Run this query: Right-click on the query editor, then click CodeQL: Run Query.
Inspect the results appearing in the results panel. Click on the result hyperlinks to navigate to the corresponding locations in the Bootstrap code. Do you understand what this query does? You probably guessed it! This query finds all calls to the function named
$
.Now it's time to submit your query. You will have 2 choices to do that, and we'll explain both of them in the comments below. Once you have chosen your method, submit your answer!
Read carefully: you will need to follow the same steps to submit your answers to later steps. You can always come back to this issue later to check the submission instructions.