preaction / Log-Any

Simple, fast Perl logging API compatible with any logging system
Other
13 stars 19 forks source link

Test failure in stringifying on 1.717 for Mojolicious < 8.22 #101

Open duffee opened 1 year ago

duffee commented 1 year ago

Found this test fail today when building Log::Any 1.717 with Mojolicious 7 (which caused confusion when "well, it worked on my machine" with an up-to-date Mojo).

#   Failed test 'default log with Mojo::Exception message - message stringifies correctly'
#   at t/proxy-with-stack-trace.t line 358.
#                   'Help!'
#     doesn't match '(?^:^Help! at t/proxy-with-stack-trace\.t line \d+\.)'

#   Failed test 'proxy log with Mojo::Exception message - message stringifies correctly'
#   at t/proxy-with-stack-trace.t line 358.
#                   'Help!'
#     doesn't match '(?^:^Help! at t/proxy-with-stack-trace\.t line \d+\.)'

#   Failed test 'proxy log show args with Mojo::Exception message - message stringifies correctly'
#   at t/proxy-with-stack-trace.t line 358.
#                   'Help!'
#     doesn't match '(?^:^Help! at t/proxy-with-stack-trace\.t line \d+\.)'
# Looks like you failed 3 tests of 241.

Mojolicious fixed this in 8.22

~Temporary solution will be to pin the Log::Any version until Mojo Is upgraded~ Another of our dependancies pulls in the latest version of Log::Any, foiling the pin in our cpanfile. Installing sooner in the build pipeline.

Raising the issue for awareness.

dakkar commented 1 year ago

since Mojolicious is not a dependency of Log::Any, I'd suggest tweaking the tests to accept the old behaviour as well