search

preaction / Minion-Backend-mysql

MySQL backend for the 🐙 Minion job runner
Other
7 stars 14 forks source link

Added list_locks support for mysql backend #17

Closed pentabion closed 6 years ago

pentabion commented 6 years ago

Added list_locks to make Minion::Admin works without failures :)

preaction commented 6 years ago

Thanks for the patch! We will need a test for this, though. That probably means copying the t/pg_admin.t test from the Minion distribution and making it work correctly with this distribution. Once we have a test, this can be released.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-5.9%) to 92.935% when pulling a5df639cc8da96e0d9429a09b691f81af144b29c on pentabion:master into 1796dab6a5d8d0efc314ac6e7792f71a419108c6 on preaction:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.08%) to 98.925% when pulling d9e45cb3b9951ce4b669fa410b6fc41deadbce1f on pentabion:master into 1796dab6a5d8d0efc314ac6e7792f71a419108c6 on preaction:master.

pentabion commented 6 years ago

Added list_lock tests. Fixed behaviour according to original module

pentabion commented 6 years ago

t/mysql.t:768 --> is_deeply $job->info->{parents}, [$id, $id2], 'right parents'; Is unstable. Maybe we could reset DB (minion_jobs) right before this group of tests. ...or remove this assert :)

pentabion commented 6 years ago

@preaction piu piu. Let's merge the patch :) I could comment unstable test ))

preaction commented 6 years ago

The unstable test isn't part of your work, so I've squashed/merged it and will make a release shortly. Thanks for the patch!