It doesn't work for Minion >= 9.0. Fixed

pentabion commented 6 years ago

According to Changes file: ... 9.0 2018-04-15

Replaced queue, state and task options of list_jobs method in Minion::Backend::Pg with queues, states and tasks options.
Replaced name option of list_locks method in Minion::Backend::Pg with names option. ...

pentabion commented 6 years ago

Hi there! Sorry for many commits, but it finally works. I'll try to fix annoying failed test soon: "Failed test 'right parents'"

coveralls commented 6 years ago

Coverage increased (+0.01%) to 98.936% when pulling 7494da40ccf756ddd5feebfbe93d2c6e682ead39 on pentabion:master into b27088174b641194db11abb92a7a8b1a407252cf on preaction:master.

pentabion commented 6 years ago

piu piu @preaction

preaction commented 6 years ago

Thanks! I've merged this in to master (and cleaned it up a bit) and released it in v0.14, but for next time you should make sure that you are starting your branch from my master. It looks like instead you merged my master into your master and kept going, which means some earlier commits got stuck in.

The easy way to do this would be git checkout -b <branch-name> upstream/master. This will create a new branch called <branch-name> that starts from upstream/master. This assumes you have an upstream remote (git remote add upstream https://github.com/preaction/Minion-Backend-mysql.git) and that it is up to date (git fetch upstream).

If you do this, it will be a lot easier for me to merge in your changes, and to see what's really changed in the pull request.

Thanks again!

pentabion commented 6 years ago

Yep, that's my fall, I'm sorry. And thank you for merging the patch! By the way there is also was added history call support for Minion::Admin

preaction / Minion-Backend-mysql

It doesn't work for Minion >= 9.0. Fixed #18