search

preaction / Statocles

Static website CMS
http://preaction.me/statocles
Other
84 stars 33 forks source link

Test cleanup #469

Closed kentfredric closed 8 years ago

kentfredric commented 8 years ago

Closes #468 by superseding it.

I've left test_pages in place for now as it doesn't appear to use any of the "hot" dependencies, with the exception of Test::More

I attempted to use it myself somewhere, until I found it didn't work for me and it was easier to roll my own solution to that part, but I still have the import in place.

Will probably nuke that function in a later commit. Nuked.

kentfredric commented 8 years ago

I should probably put some stubs/hooks in Statocles::Test for the now missing functions in case somebody was using them :/

preaction commented 8 years ago

Yeah, if we're going to commit to an upgrade policy (Statocles::Help::Policy), we might as well commit. I've been leaving annoying warnings detailing when the feature's to be removed (this would be 2.0), and a test in t/deprecated.t that makes sure I remove the feature when 2.0 hits

kentfredric commented 8 years ago

Rebased and restored all the stub things, as well as a bunch of other fixes to reduce the potential fallout from the missing dependency while deprecation is still "pending".

Deprecation tests added.

preaction commented 8 years ago

Rebased and merged. The travis test failures are spurious due to the Path::Tiny fixes that I made before merging this (and is why I had to rebase). Thanks!