Open dertuxmalwieder opened 8 years ago
Wow. I clearly have neglected Windows for too long. There's at least 7 issues here:
C:
is likely Statocles not doing Path::Tiny correctlyChild (blog with two posts in the same day) exited without calling finalize()
is new and I'll have to track that one down furtherremove_tree failed for C:\Users\hp\AppData\Local\Temp\hyfKnWzv6d\build_site\deploy_foo\theme\css: cannot remove directory: Directory not empty
is probably me holding open a file handle, which Windows does not allow deleting files that have open handles.Error rename on 'C:/Users/hp/AppData/Local/Temp/ykoYZtpxrK/theme/site/footer.html.ep67002120342481' -> 'C:/Users/hp/AppData/Local/Temp/ykoYZtpxrK/theme/site/footer.html.ep': Permission denied
is the one Windows bug that I have seen but can't reliably reproduce. It happens a lot on CPAN Testers.nothing to deploy bails out without commit
is a weird one.Looks like 3 of them I already knew about and reported in #472 and one other is in #110.
TL;DR: I need to make a Windows VM. It needs to have German or some other language pack installed.
If you can help triage and trace the ones I don't understand, that would be super helpful. I've been away from Windows since early XP days, so I don't know a lot about how Windows differs from Unix-likes.
The t/app/blog/command.t has to be a line-ending problem or an encoding problem
Depends. I could change it. What are the expected settings?
On Oct 24, 2016, at 1:29 PM, Cthulhux notifications@github.com wrote:
The t/app/blog/command.t has to be a line-ending problem or an encoding problem
Depends. I could change it. What are the expected settings?
I mean on Statocles's side. Either it's expecting an encoding or it's expecting a line ending and it's not getting it. It's hard to tell because whatever the problem is looks invisible...
But, for triage's sake, does the bug disappear if you're in a US English locale?
How can I change the test language?
On Windows? Excellent question. Maybe it's this? https://java.com/en/download/help/locale.xml I think it's more that you have to change it for the whole machine temporarily.
Otherwise, you might be able to edit the test file to do a call to POSIX::setlocale
with something like use POSIX qw( setlocale LC_ALL ); setlocale( LC_ALL, "C" );
Restart the computer to apply the change.
Nah, not worth it. I'll just edit the test file. :-)
use POSIX qw( setlocale LC_ALL );
setlocale( LC_ALL, "C" );
No improvements with these additions, the same error happens. :-(
@dertuxmalwieder I just successfully ran the tests on Windows for version 0.089. Could you try this and if it works, this issue could be closed?
I'll be back on Wednesday, I will try then!
Hmm...
Test Summary Report
-------------------
t/10-command.t (Wstat: 1792 Tests: 140 Failed: 7)
Failed tests: 11, 28, 45, 62, 79, 96, 113
Non-zero exit status: 7
t/20-zombie.t (Wstat: 1536 Tests: 36 Failed: 10)
Failed tests: 11-12, 29-36
Non-zero exit status: 6
Parse errors: Bad plan. You planned 30 tests but ran 36.
Files=14, Tests=247, 25 wallclock secs ( 0.05 usr + 0.08 sys = 0.12 CPU)
Result: FAIL
Failed 2/14 test programs. 17/247 subtests failed.
gmake: *** [Makefile:889: test_dynamic] Error 255
BOOK/System-Command-1.118.tar.gz
C:\Perl_x86\c\bin\gmake.exe test -- NOT OK
//hint// to see the cpan-testers results for installing this module, try:
reports BOOK/System-Command-1.118.tar.gz
Stopping: 'install' failed for 'System::Command'.
Failed during this command:
BOOK/System-Command-1.118.tar.gz : make_test NO
Yeah, that's the prereq that requires --notest
or --force
. We might be able to fix that by switching to Git::Wrapper, I'm not sure
I guess having to specify notest
is still not the best idea. However, cpan notest install Statocles
gives me (among a number of Test::
modules which probably shouldn't be needed...?) a working Statocles.
Hope that helps? (I'll leave my Windows machine until Friday evening in a few minutes ... :-))
@dertuxmalwieder I PR-ed fixes for System::Command
on Windows which have been merged, but not yet released. You might open an issue on the repo to seek a release. cf https://github.com/book/System-Command/issues/23
I'll just watch that issue, I guess. No reason to spam them with new ones. :-)
As promised, here's the "test" part from the installation. (Statocles itself builds fine.)