search

preaction / Statocles

Static website CMS
http://preaction.me/statocles
Other
84 stars 33 forks source link

html_lint.t test started to fail #526

Closed eserte closed 7 years ago

eserte commented 7 years ago

On some of my smokers the html_lint.t test started to fail:

    #   Failed test 'lint problems found'
    #   at t/plugin/html_lint.t line 22.
    # Comparing $data as a Bag
    # Extra: 31 references
    # [
    #   [
    #     1484775289,
    #     'warn',
    #     'Lint failures on /blog/2014/04/23/slug/index.html:'
    #   ],
    #   [
    #     1484775289,
    #     'warn',
    #     '- (76:1) The eof() method has not been called on this file.'
    #   ],
    #   [
    #     1484775289,
    #     'warn',
    #     '- (76:1) The eof() method has not been called on this file.'
    #   ],
...
    #   [
    #     1484775289,
    #     'warn',
    #     '- (45:1) The eof() method has not been called on this file.'
    #   ]
    # ]
    # Looks like you failed 1 test of 1.

#   Failed test 'check html'
#   at t/plugin/html_lint.t line 53.
# Looks like you failed 1 test of 1.
t/plugin/html_lint.t .......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests

Probably this is related to this change in HTML-Lint: https://metacpan.org/source/PETDANCE/HTML-Lint-2.26/Changes#L20

preaction commented 7 years ago

Argh! I literally fixed this a month ago (https://github.com/preaction/Statocles/commit/bbc5e3f0f4b11b41d595cba999044d22e1aac943), when Andy asked for feedback on exactly this change to HTML::Lint, but then I completely forgot to release the new version... I will release 0.082 now, and that should fix this issue. Thanks for the report!