search

preaction / Statocles

Static website CMS
http://preaction.me/statocles
Other
84 stars 33 forks source link

Diagram plugins #545

Closed kiwiroy closed 6 years ago

kiwiroy commented 6 years ago

Summary

A plugin to render diagrams using mermaid.

References

Issue #525

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.09%) to 91.974% when pulling 300c390664534e2fb5f66ef344120092772ae44e on kiwiroy:diagram-plugins into 4bb53b04603c9f9693a3d7406fbe11e3b0a9598c on preaction:master.

kiwiroy commented 6 years ago

I started a Ditaa plugin also.

preaction commented 6 years ago

This looks great. I totally didn't know Mermaid could do Gantt charting, but this is great.

I like the idea of using a script link's text to add a bit of javascript to the header (or whereever the theme puts the JS), but we are going to need to test that all the themes handle that situation properly. There's another test, t/theme/check.t that tests all the themes. There's a sub test_layout_content that has tests that all themes must pass. Add a simple test there to make sure that the text version of a JS link is supported and this is good to go.

Thanks for the patch!

preaction commented 6 years ago

This still needs a test added to t/theme/check.t. Would you like me to add one so this can be merged?

kiwiroy commented 6 years ago

@preaction please go ahead.

preaction commented 6 years ago

This is added to master now. Thanks!