preaction / Statocles

Static website CMS
http://preaction.me/statocles
Other
84 stars 33 forks source link

Patch: 'Older' and 'Newer' buttons on the blog are always absolute links #582

Closed wbazant closed 4 years ago

wbazant commented 4 years ago

I think the flow goes like this now:

After some bisecting I've found this got broken in the commit f7c8d5b98, which it has some changes to Statocles::Site::_fix_internal_links but I can't quite see what happened.

I've found this because the link checker complained about the links being broken - and it speaks to the quality of this patch that the link checker still complains about stuff - but you might prefer to have it rather than not

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 89.921% when pulling dac17b1d4b8083781d0ac2978fb2df16ab8e725b on wbazant:master into 3e13a9040721b3306dd734d1189cb538c837ef03 on preaction:master.

preaction commented 4 years ago

Thanks! I, too, am not sure what happened, but it probably has a lot to do with the aborted, half-finished, reverted refactor.