search

preaction / Statocles

Static website CMS
http://preaction.me/statocles
Other
84 stars 33 forks source link

Avoid using reserved Mojolicious stash value #605

Closed ferki closed 3 years ago

ferki commented 3 years ago

This PR is an attempt to fix #604 by avoiding to use the path as stash value which is apparently a reserved one since at least Mojolicious-9.0.

Please review and merge, or let me know how to improve it.

jberger commented 3 years ago

I think the placeholder in the route needs to change too, i.e. /*path_to_change

ferki commented 3 years ago

I think the placeholder in the route needs to change too, i.e. /*path_to_change

Good catch, thanks! I'll fix it in a moment.

preaction commented 3 years ago

Thanks! I've renamed the variable to slug to keep in line with other changes I've made in other projects, and I fixed the test failures from (I think) Path::Tiny / YAML interactions. I'll release this presently.

ferki commented 3 years ago

Thank you, @preaction! :tada: