preaction / Yancy

The Best Web Framework Deserves the Best Content Management System
http://preaction.me/yancy/
Other
54 stars 21 forks source link

Typo in yancy/app.js #109

Closed uniejo closed 4 years ago

uniejo commented 4 years ago

A recent change prevents loading of yancy editor. It looks like a typo with a 's' too much ( s/definitions/definition/ ). After removing the 's', it loads again.

--- a/lib/Mojolicious/Plugin/Yancy/resources/public/yancy/app.js +++ b/lib/Mojolicious/Plugin/Yancy/resources/public/yancy/app.js @@ -592,7 +592,7 @@ var app = window.Yancy = new Vue({

             for ( var propKey in definition.properties ) {
                 var prop = definition.properties[ propKey ];
preaction commented 4 years ago

Thanks! Clearly there's no test for that feature (markdown fields in the editor), so I'll have to add one to prevent this from happening again