search

preaction / Yancy

The Best Web Framework Deserves the Best Content Management System
http://preaction.me/yancy/
Other
54 stars 21 forks source link

Added missing prereq Role::Tiny as suggested by CPANTS. #16

Closed manwar closed 6 years ago

manwar commented 6 years ago

Hi @preaction

Please review the PR.

Many Thanks. Best Regards, Mohammad S Anwar

preaction commented 6 years ago

This is what I get for releasing while tired: I told myself "Remember to include Role::Tiny as a prereq if you're going to use roles like this."

So, this is the right change, but the wrong place. I use Dist::Zilla to generate the cpanfile. This keeps happening, so I've submitted a PR to Dist-Zilla to add a header to the cpanfile to steer folks in the right direction: https://github.com/rjbs/Dist-Zilla/pull/629

I'll add the change to the right place. Thanks for the help!

manwar commented 6 years ago

Again, I learnt that cpanfile can also be generated using Dist::Zilla. I thought it was always created manually. Your PR would make it clear to people like me next time. So thanks for sharing the knowledge.