eserte commented 5 years ago

See https://metacpan.org/changes/distribution/JSON-Validator#L14 (FYI: @jhthorsen)

This means Yancy's test suite currently fails:

#   Failed test 'Mojolicious/Plugin/Yancy.pm loaded ok'
#   at t/00-compile.t line 53.
#          got: '512'
#     expected: '0'
Can't locate JSON/Validator/OpenAPI.pm in @INC (you may need to install the JSON::Validator::OpenAPI module) (@INC contains: ... .) at /home/cpansand/.cpan/build/2019010609/Yancy-1.020-1/blib/lib/Mojolicious/Plugin/Yancy.pm line 408.
BEGIN failed--compilation aborted at /home/cpansand/.cpan/build/2019010609/Yancy-1.020-1/blib/lib/Mojolicious/Plugin/Yancy.pm line 408.
Compilation failed in require at -e line 1.
# Looks like you failed 1 test of 10.
t/00-compile.t ............... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/10 subtests 
    (less 1 skipped subtest: 8 okay)
... (etc)...

jhthorsen commented 5 years ago

I'm not sure why M::P::Yancy use JSON::Validator::OpenAPI. There shouldn't be any reason to depend on that directly.

mohawk2 commented 5 years ago

Confirmed. This makes Yancy work correctly again:

cpanm JSON::Validator@2.19 Mojolicious::Plugin::OpenAPI@2.07

mohawk2 commented 5 years ago

I believe the manual use of JSON::Validator started as a solution to #13, which then switched to JSON::Validator::OpenAPI with 7e06ef80b49c901f52c6113ba795c3bd77e38b41.

mohawk2 commented 5 years ago

The JV bug-fix on coercion has broken Yancy which also does a form of coercion. I believe I am on track to fix this.

mohawk2 commented 5 years ago

preaction / Yancy

JSON::Validator::OpenAPI was removed #44

45 ought to fix.