preaction / Yancy

The Best Web Framework Deserves the Best Content Management System
http://preaction.me/yancy/
Other
54 stars 21 forks source link

Added missing prereq DBI as suggested by CPANTS. #65

Closed manwar closed 5 years ago

manwar commented 5 years ago

Hi @preaction

Please review the PR.

Many Thanks. Best Regards, Mohammad S Anwar

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 92.786% when pulling ab8e2ffb1def8880882d8a855945cae1fefaa42d on manwar:missing-prereq into 0195e1c3289ff685c9836b8d6a2227fc75f7b96e on preaction:master.

preaction commented 5 years ago

This is mostly a false-positive by CPANTS: The DBI requirement is satisfied by the individual Mojo:: database module required by the backend modules for SQLite, Postgres, and MySQL. If the individual Mojo:: database module isn't installed, loading the backend will throw an exception telling the user to install that module.

Is there something I can do to help CPANTS understand that?

manwar commented 5 years ago

Don't worry, please ignore the PR. Sorry for the inconvenience.