Three-eyed checkbox - Githubissues

preaction / Yancy

The Best Web Framework Deserves the Best Content Management System

http://preaction.me/yancy/

Other

54 stars 21 forks source link

Three-eyed checkbox #73

Closed wbazant closed 4 years ago

wbazant commented 4 years ago

Show an undefined value for a boolean field as neither a yes nor a no
fixes a bug where the app wouldn't propagate a default value of zero, empty string, or a Boolean false
I noticed a "Yes" field is one character longer than a "No" field: give them a minimal width

coveralls commented 4 years ago

Coverage remained the same at 93.164% when pulling 5fcf7653805352d071553cbb48b04c10fcdbe92b on wbazant:three-eyed-checkbox into 11b9554cab894f5ed6f9d88b53903ac17cba36ed on preaction:master.

preaction commented 4 years ago

Ahh, good old ternary logic. This is great, thanks! We may, down the road, need some way to allow folks to "unset" a yes/no back to null, but I think that's something we can wait until it becomes an issue.

wbazant commented 4 years ago

@preaction it's totally correct that the user embarks on a way of no return once they start fiddling with a yes and no buttons. They can View Raw if they're entrepreneurial - at least that's what I did when testing.