Fetch PR base sha instead of the current state of the PR target

preactjs / compressed-size-action

GitHub Action that adds compressed size changes to your PRs.

https://github.com/marketplace/actions/compressed-size-action

MIT License

602 stars 84 forks source link

Fetch PR base sha instead of the current state of the PR target #11

Closed youknowriad closed 4 years ago

youknowriad commented 4 years ago

closes #10

I've very new to Github actions, so I'm not sure how to test this properly (I'm going to try in a personal repo).

Anyway, I saw that the target checkout was done on purpose and the checkout to the base sha was considered a fallback. I'd like to know more about the reasons cause IMO using the current state of the target branch for comparison can lead to unexpected numbers if the PR is not fresh enough.

youknowriad commented 4 years ago

After some tests the base.sha value doesn't seem to contain the correct hash but more the hash of the target branch at the moment the PR is created or something like that. I'm closing this while trying to figure out a better solution.