search

preactjs / compressed-size-action

GitHub Action that adds compressed size changes to your PRs.
https://github.com/marketplace/actions/compressed-size-action
MIT License
602 stars 84 forks source link

Doesn't find build artifacts in nested folder in dist #23

Closed ricokahler closed 4 years ago

ricokahler commented 4 years ago

I have a bit of an edge case setup where:

  1. it's a monorepo, building multiple packages into dist at once
  2. each package's build artifact goes into /dist/package-1/index.esm.js

It seems like compressed-size-action isn't finding the /dist/package-1/index.esm.js. Looking into the code here, it seems like the default glob pattern (i.e. **/dist/**/*.js) should match my files.

Below is a screenshot of my test in globster where the highlighted files are the matched files.

image

If it helps, you can see the result my CI run here.

Hope that helps fix this issue and thanks a bunch for this awesome action!

kroofy commented 4 years ago

Could you try changing to v2? That fixed it for me.

- uses: preactjs/compressed-size-action@v2
ricokahler commented 4 years ago

@kroofy I gave that a go. Still nothin'

ricokahler commented 4 years ago

Oh wow, I just realized I updated checkout instead of compressed-size in my github workflow file. I actually updated to v2 and it's working now. 🤦‍♀️

kroofy commented 4 years ago

Glad to hear it worked out!