search

preactjs / compressed-size-action

GitHub Action that adds compressed size changes to your PRs.
https://github.com/marketplace/actions/compressed-size-action
MIT License
601 stars 84 forks source link

Add comment-key input #82

Closed sarayourfriend closed 1 month ago

sarayourfriend commented 2 years ago

Addresses #81 using the suggested implementation.

I'm not totally sure how changes to this are tested, mostly because the CI only runs the action with limited options. Open to recommendations for how to properly test this.

sarayourfriend commented 2 years ago

@developit any chance this can get feedback sometime?

sarayourfriend commented 1 year ago

@developit Is it possible this PR could get a review?

sarayourfriend commented 1 year ago

@developit Any chance for a review here?

sarayourfriend commented 7 months ago

Closing this PR to clean up my list of open PRs. Please ping me if you'd like me to reopen the PR.

sarayourfriend commented 1 month ago

@JoviDeCroock @rschristian are either of y'all able to review this PR? (Just picking the last couple folks I see reviewing and merging in this repository, hope that's okay)

rschristian commented 1 month ago

Thanks for the ping, I'll definitely try to take a look. Just need to figure out how to test it.

sarayourfriend commented 1 month ago

All good, thanks for the review. I've pushed changes with docs to the README and resolved the merge conflict.