Closed mmckenziedev closed 1 year ago
@estherkim Did you previous PR solve your deprecation warning?
@developit @JoviDeCroock Please review?
Are you seriously tagging me for something you just opened?
Are you seriously tagging me for something you just opened?
I don't know who reviews changes in this repo. You approved the last PR that was supposed to resolve this issue so you seemed like a likely candidate? Sorry if I broke some protocol.
Tagging people is generally a way to get attention if something has gone unnoticed for a while. Most of us have some sort of notifications set up and will get to things eventually.
So tagging specific people for a review less than 10 minutes after opening can be seen as a bit rude in any OSS project, as maintaining this stuff isn't our day job or anything we're really paid for. It's something we do in our free time, when we can. It comes off as a bit demanding, which is what I think Jovi was hinting at.
Rest assured, someone will take a look eventually.
The Github actions
actions/checkout@v2
andactions/setup-node@v1
need to be updated to the latest versions to be in compliance with Github's node@12 deprecation. I believe the following warning is due to these actions being out of date.I don't think https://github.com/preactjs/compressed-size-action/pull/87 fully solved this problem
From the link:
In my own projects I updated these actions to the latest major versions and the deprecation warning went away.
I imagine this change would be a major version upgrade as I had to add these new versions to my project's allowed list of actions, otherwise I receive this warning and the actions fail to execute.