search

preactjs / compressed-size-action

GitHub Action that adds compressed size changes to your PRs.
https://github.com/marketplace/actions/compressed-size-action
MIT License
602 stars 84 forks source link

chore: Update Github actions to latest versions #90

Closed mmckenziedev closed 1 year ago

mmckenziedev commented 1 year ago

The Github actions actions/checkout@v2 and actions/setup-node@v1 need to be updated to the latest versions to be in compliance with Github's node@12 deprecation. I believe the following warning is due to these actions being out of date.

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: preactjs/compressed-size-action@2.5.0. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

I don't think https://github.com/preactjs/compressed-size-action/pull/87 fully solved this problem

From the link:

Node 12 has been out of support since April 2022, as a result we have started the deprecation process of Node 12 for GitHub Actions. We plan to migrate all actions to run on Node16 by Summer 2023. We will monitor the progress of the migration and listen to the community for how things are going before we define a final date. To raise awareness of the upcoming change, we are adding a warning into workflows which contain Actions running on Node 12. This will come into effect starting on September 27th.

In my own projects I updated these actions to the latest major versions and the deprecation warning went away.

I imagine this change would be a major version upgrade as I had to add these new versions to my project's allowed list of actions, otherwise I receive this warning and the actions fail to execute.

Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following < list of existing actions >

mmckenziedev commented 1 year ago

@estherkim Did you previous PR solve your deprecation warning?

mmckenziedev commented 1 year ago

@developit @JoviDeCroock Please review?

JoviDeCroock commented 1 year ago

Are you seriously tagging me for something you just opened?

mmckenziedev commented 1 year ago

Are you seriously tagging me for something you just opened?

I don't know who reviews changes in this repo. You approved the last PR that was supposed to resolve this issue so you seemed like a likely candidate? Sorry if I broke some protocol.

rschristian commented 1 year ago

Tagging people is generally a way to get attention if something has gone unnoticed for a while. Most of us have some sort of notifications set up and will get to things eventually.

So tagging specific people for a review less than 10 minutes after opening can be seen as a bit rude in any OSS project, as maintaining this stuff isn't our day job or anything we're really paid for. It's something we do in our free time, when we can. It comes off as a bit demanding, which is what I think Jovi was hinting at.

Rest assured, someone will take a look eventually.