search

preactjs / preact-compat

ATTENTION: The React compatibility layer for Preact has moved to the main preact repo.
http://npm.im/preact-compat
MIT License
949 stars 148 forks source link

Issues when rendering rows on react-table #460

Closed navaru closed 6 years ago

navaru commented 6 years ago

Original example that works: https://codesandbox.io/s/wjrn8wy3R

Exact example using preact-compat: https://codesandbox.io/s/n3o9j013rj Switch the rows count from 10 to 5 and back to 10.

I've checked the react-table source (adding logs) and the children count passed to the TbodyComponent are correct, but when rendered somehow it adds the old children from the virtual-dom, hope it helps.

Ehernandez0921 commented 6 years ago

It looks like they are resolving it in the react-table library. @rantecki has made the change and it needs to get reviewed. I don't know how to reference from another repository.

(https://github.com/react-tools/react-table/issues/827)

navaru commented 6 years ago

So it's not related to preact, rantecki caught the error source. Thanks for feedback.