search

preactjs / preact-router

:earth_americas: URL router for Preact.
http://npm.im/preact-router
MIT License
1.01k stars 156 forks source link

rm type for `default` attribute #440

Closed srsudar closed 1 year ago

srsudar commented 1 year ago

This is an attempted fix for this issue on the main preact project:

https://github.com/preactjs/preact/issues/3934

New versions of preact include SignalLike<boolean> as a valid type for the default attribute. It was suggested by a preact maintainer that the default value defined here is unnecessary, as it should match what is provided by preact.

rschristian commented 1 year ago

Looks like #433 was another attempt (though it also has issues), and we also talked a bit about it here: https://github.com/preactjs/wmr/pull/955

Sorry, discussion is a bit spread out

rschristian commented 1 year ago

Superseded by #452

srsudar commented 1 year ago

Thank you!

rschristian commented 1 year ago

Certainly let me know if you still have any issues, but fingers crossed that this is fixed.