preactjs / preact-www

:book: Preact documentation website.
https://preactjs.com
MIT License
358 stars 500 forks source link

fix: Match tutorial loading state to Router #1143

Closed rschristian closed 4 months ago

rschristian commented 4 months ago

Admittedly this is a bit of a hack, but the tutorial pages have their own loading state which isn't quite correct anymore and is therefore creating a bit of jank when you switch between the steps (/01-vdom -> /02-events). This solution probably isn't perfect but it improves the situation quite a bit (from my testing, lmk if anyone sees anything different) for the time being until I get to properly refactor it.

I didn't touch the tutorial much during the preact-cli/preact-router -> vite/preact-iso refactor, probably just needs a bit of a touch up to align with the other pages but that'll take some time. For now, this drilling seems to help.