search

preactjs / preact

⚛️ Fast 3kB React alternative with the same modern API. Components & Virtual DOM.
https://preactjs.com
MIT License
36.64k stars 1.95k forks source link

feat: Add popover types #4378

Closed rschristian closed 4 months ago

rschristian commented 4 months ago

Reference:

popover="hint" hasn't yet landed in the spec and as such is perhaps questionable. It seems likely that it will and I figure jumping the gun on implementation might be slightly better than needing to be pinged to add it later (as it's not a spec I'm watching), but happy to remove it if it's undesirable.

coveralls commented 4 months ago

Coverage Status

coverage: 99.609%. remained the same when pulling 598765e81dd1f841134a2da7803bcd1860bf6498 on types/popover into 1b4e6835c0685e82e46bde04097e4493e9ec35af on main.

rschristian commented 4 months ago

One sec, I need to check the camel cased versions, that might be no good as the JS property is slightly different

Should be all bueno here, rts might need a fix up for the reflected attrs, depending on whether we consider that an issue