preactjs / preact

⚛️ Fast 3kB React alternative with the same modern API. Components & Virtual DOM.

https://preactjs.com

MIT License

36.35k stars 1.93k forks source link

render() with popover doesn't work #4380

Closed codedread closed 1 month ago

codedread commented 1 month ago

[ ] Check if updating to the latest Preact version resolves the issue

Describe the bug As per this link the popover attribute is available in all browser. However, I get a complaint with Preact 10.21.0: render(<div popover>foo</div):

"Popover not assignable to type htmlattributes htmldivelement"

To Reproduce

See the above snippet. Also this react bug.

rschristian commented 1 month ago

Just a type error or an actual functional issue?

4378 addresses the types

codedread commented 1 month ago

Yes, I think it's just a type error. Functionality it seems to work.