only check is connected for dom nodes

[JoviDeCroock]

isConnected is not present on text nodes, this prevents us from crashing due to calling getDomSibling for a text node. This does highlight that Google Translate leads to a bug, in the example given in https://github.com/preactjs/preact/pull/4318#issuecomment-2168889078 we get the following as output

This is translated to Dutch, as you can see the h1 and the first hello reconcile correctly, however everything after the interpolated {label} does not.

When I replace {props.label} with a normal string or with <span>{props.label}</span> it does work correctly.

This does however not solve the other issue mentioned on this PR, which does not have a way to reproduce. I reckon that one could be related to the dom-sibling of oldVNode also not being connected due to removing a lot of fragment-like wrapped children and oldDom being captured to the first of said list.

[github-actions[bot]]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -1% - +0% (-11.43ms - +2.83ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -3% - +2% (-0.57ms - +0.33ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -5% - +3% (-3.31ms - +1.99ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -2% - +2% (-0.33ms - +0.31ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -3% - +1% (-2.43ms - +1.15ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -5% - +3% (-0.10ms - +0.06ms)
  ^{preact-local vs preact-main}
• todo: faster ✔ 4% - 7% (1.11ms - 1.92ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -4% - +2% (-1.43ms - +0.65ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -2% - +2% (-0.30ms - +0.30ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.04ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1557
• Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	866.04ms - 872.89ms	-	unsure 🔍 -1% - +0% -11.43ms - +2.83ms
preact-main	867.51ms - 880.02ms	unsure 🔍 -0% - +1% -2.83ms - +11.43ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.15ms - 25.15ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	25.15ms - 25.15ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1557
• Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.65ms - 17.07ms	-	unsure 🔍 -3% - +2% -0.57ms - +0.33ms
preact-main	16.58ms - 17.38ms	unsure 🔍 -2% - +3% -0.33ms - +0.57ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.69ms - 1.69ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.69ms - 1.69ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1557
• Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	68.84ms - 72.11ms	-	unsure 🔍 -5% - +3% -3.31ms - +1.99ms
preact-main	69.04ms - 73.22ms	unsure 🔍 -3% - +5% -1.99ms - +3.31ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	13.13ms - 13.59ms	-	unsure 🔍 -2% - +2% -0.30ms - +0.30ms
preact-main	13.17ms - 13.54ms	unsure 🔍 -2% - +2% -0.30ms - +0.30ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1557
• Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	18.18ms - 18.71ms	-	unsure 🔍 -2% - +2% -0.33ms - +0.31ms
preact-main	18.28ms - 18.63ms	unsure 🔍 -2% - +2% -0.31ms - +0.33ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.61ms - 4.61ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	4.61ms - 4.61ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

replace1k

• Browser: chrome-headless
• Sample size: 100
• Built by: Benchmarks #1557
• Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	81.45ms - 84.07ms	-	unsure 🔍 -3% - +1% -2.43ms - +1.15ms
preact-main	82.18ms - 84.62ms	unsure 🔍 -1% - +3% -1.15ms - +2.43ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.54ms - 3.57ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.04ms
preact-main	3.52ms - 3.56ms	unsure 🔍 -1% - +0% -0.04ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.89ms - 30.45ms	-	unsure 🔍 -1% - +1% -0.42ms - +0.42ms
preact-main	29.86ms - 30.49ms	unsure 🔍 -1% - +1% -0.42ms - +0.42ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.42ms - 37.48ms	-	unsure 🔍 -3% - +4% -1.26ms - +1.52ms
preact-main	35.40ms - 37.26ms	unsure 🔍 -4% - +3% -1.52ms - +1.26ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.11ms - 27.59ms	-	unsure 🔍 -1% - +2% -0.26ms - +0.43ms
preact-main	27.01ms - 27.51ms	unsure 🔍 -2% - +1% -0.43ms - +0.26ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.72ms - 35.66ms	-	unsure 🔍 -3% - +4% -1.06ms - +1.45ms
preact-main	33.70ms - 35.29ms	unsure 🔍 -4% - +3% -1.45ms - +1.06ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.60ms - 24.33ms	-	unsure 🔍 -1% - +8% -0.30ms - +1.81ms
preact-main	22.10ms - 23.32ms	unsure 🔍 -8% - +1% -1.81ms - +0.30ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.30ms - 26.55ms	-	unsure 🔍 -2% - +5% -0.51ms - +1.30ms
preact-main	24.87ms - 26.18ms	unsure 🔍 -5% - +2% -1.30ms - +0.51ms	-

text-update

• Browser: chrome-headless
• Sample size: 100
• Built by: Benchmarks #1557
• Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.95ms - 2.06ms	-	unsure 🔍 -5% - +3% -0.10ms - +0.06ms
preact-main	1.96ms - 2.08ms	unsure 🔍 -3% - +5% -0.06ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.98ms - 0.98ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	0.98ms - 0.98ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

• Browser: chrome-headless
• Sample size: 120
• Built by: Benchmarks #1557
• Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.59ms - 25.75ms	-	faster ✔ 4% - 7% 1.11ms - 1.92ms
preact-main	26.79ms - 27.58ms	slower ❌ 4% - 7% 1.11ms - 1.92ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.25ms - 1.25ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-main	1.25ms - 1.25ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1557
• Commit: 75f1b71

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.18ms - 36.07ms	-	unsure 🔍 -4% - +2% -1.43ms - +0.65ms
preact-main	35.08ms - 36.96ms	unsure 🔍 -2% - +4% -0.65ms - +1.43ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.55ms - 3.55ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-main	3.55ms - 3.55ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[github-actions[bot]]

Size Change: +39 B (+0.06%)

Total Size: 61.8 kB

Filename	Size	Change
dist/preact.js	4.68 kB	+7 B (+0.15%)
dist/preact.min.js	4.71 kB	+6 B (+0.13%)
dist/preact.min.module.js	4.71 kB	+6 B (+0.13%)
dist/preact.min.umd.js	4.74 kB	+6 B (+0.13%)
dist/preact.module.js	4.7 kB	+9 B (+0.19%)
dist/preact.umd.js	4.75 kB	+5 B (+0.11%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `compat/dist/compat.js` | 4.1 kB | | `compat/dist/compat.module.js` | 4.03 kB | | `compat/dist/compat.umd.js` | 4.17 kB | | `debug/dist/debug.js` | 3.7 kB | | `debug/dist/debug.module.js` | 3.71 kB | | `debug/dist/debug.umd.js` | 3.78 kB | | `devtools/dist/devtools.js` | 259 B | | `devtools/dist/devtools.module.js` | 273 B | | `devtools/dist/devtools.umd.js` | 345 B | | `hooks/dist/hooks.js` | 1.53 kB | | `hooks/dist/hooks.module.js` | 1.56 kB | | `hooks/dist/hooks.umd.js` | 1.6 kB | | `jsx-runtime/dist/jsxRuntime.js` | 981 B | | `jsx-runtime/dist/jsxRuntime.module.js` | 956 B | | `jsx-runtime/dist/jsxRuntime.umd.js` | 1.06 kB | | `test-utils/dist/testUtils.js` | 451 B | | `test-utils/dist/testUtils.module.js` | 456 B | | `test-utils/dist/testUtils.umd.js` | 536 B |

_{compressed-size-action}

[coveralls]

coverage: 99.611%. remained the same when pulling 4d8357a51a14459beaf450fa5aa8304e811bda86 on only-check-for-dom-nodes into 4c20c23c16dd60f380ce9fe98afc93041a7e1562 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 4d8357a51a14459beaf450fa5aa8304e811bda86 on only-check-for-dom-nodes into 4c20c23c16dd60f380ce9fe98afc93041a7e1562 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 0a17073a4e0e950514247afede6a18dd253e7e58 on only-check-for-dom-nodes into 4c20c23c16dd60f380ce9fe98afc93041a7e1562 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 0a17073a4e0e950514247afede6a18dd253e7e58 on only-check-for-dom-nodes into 4c20c23c16dd60f380ce9fe98afc93041a7e1562 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 0a17073a4e0e950514247afede6a18dd253e7e58 on only-check-for-dom-nodes into 4c20c23c16dd60f380ce9fe98afc93041a7e1562 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 0a17073a4e0e950514247afede6a18dd253e7e58 on only-check-for-dom-nodes into 4c20c23c16dd60f380ce9fe98afc93041a7e1562 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 0c0539100386511a4e70870ad01dd1a6448af829 on only-check-for-dom-nodes into 92e86e93268155affbd3d3152127994673771ff7 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 0c0539100386511a4e70870ad01dd1a6448af829 on only-check-for-dom-nodes into 92e86e93268155affbd3d3152127994673771ff7 on main.

[coveralls]

coverage: 99.482% (-0.1%) from 99.611% when pulling bd29648e2603aed988806f60a3480cfa13cfb22b on only-check-for-dom-nodes into eb3767723d43e8a38453efc28d187810edfa4231 on main.

[coveralls]

coverage: 99.482% (-0.1%) from 99.611% when pulling bd29648e2603aed988806f60a3480cfa13cfb22b on only-check-for-dom-nodes into eb3767723d43e8a38453efc28d187810edfa4231 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling bd29648e2603aed988806f60a3480cfa13cfb22b on only-check-for-dom-nodes into eb3767723d43e8a38453efc28d187810edfa4231 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling bd29648e2603aed988806f60a3480cfa13cfb22b on only-check-for-dom-nodes into eb3767723d43e8a38453efc28d187810edfa4231 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 75f1b7142d7045796978b60f336b0790cd884734 on only-check-for-dom-nodes into 76f5d66106e93004dad3635614b067b417c71c67 on main.

[coveralls]

coverage: 99.611%. remained the same when pulling 75f1b7142d7045796978b60f336b0790cd884734 on only-check-for-dom-nodes into 76f5d66106e93004dad3635614b067b417c71c67 on main.