search

preactjs / signals

Manage state with style in every framework
https://preactjs.com/blog/introducing-signals/
MIT License
3.79k stars 93 forks source link

Update Preact VNode adapter #268

Closed billybimbob closed 1 year ago

billybimbob commented 2 years ago

Preact expects VNodes to have an undefined constructor. This PR updates the Preact adapter so that signal objects match this expectation. The undefined constructor will only affect signal objects while the Signal Prototype is unaffected.

Fixes #256

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: f47c0d16d85174524f7324df9279f2d52a362c92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 2 years ago

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit f47c0d16d85174524f7324df9279f2d52a362c92
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/636d0d0a2002aa000768e4b9
Deploy Preview https://deploy-preview-268--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.