preactjs / signals

Manage state with style in every framework
https://preactjs.com/blog/introducing-signals/
MIT License
3.71k stars 91 forks source link

refactor: Remove non-functional `package.json#exports.umd` #373

Closed rschristian closed 1 year ago

rschristian commented 1 year ago

In all three of the packages, package.json#exports.umd has been referencing the incorrect path for the UMD bundles since release (should've been x.min.js).

However, seeing as how I can't see a single complaint relating to this, and I'm not aware of any tools that actually consume it (would love to know if there are tools that do), I elected to remove the entries. Saves us from making a breaking change in the future if we were to alter that entry in any way.

changeset-bot[bot] commented 1 year ago

đŸĻ‹ Changeset detected

Latest commit: 878245c44c494349fe1330c3986524d2e4e39551

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | --------------------- | ----- | | @preact/signals-core | Patch | | @preact/signals | Patch | | @preact/signals-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit 878245c44c494349fe1330c3986524d2e4e39551
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/649252959e9cdc000886f59b
Deploy Preview https://deploy-preview-373--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions[bot] commented 1 year ago

Size Change: 0 B

Total Size: 69.1 kB

ℹī¸ View Unchanged | Filename | Size | | :--- | :---: | | `docs/dist/assets/client.********.js` | 46.6 kB | | `docs/dist/assets/index.********.js` | 835 B | | `docs/dist/assets/jsxRuntime.module.********.js` | 282 B | | `docs/dist/assets/preact.module.********.js` | 4 kB | | `docs/dist/assets/signals-core.module.********.js` | 1.42 kB | | `docs/dist/assets/signals.module.********.js` | 1.97 kB | | `docs/dist/assets/style.********.js` | 21 B | | `docs/dist/assets/style.********.css` | 1.21 kB | | `docs/dist/basic-********.js` | 244 B | | `docs/dist/demos-********.js` | 3.35 kB | | `docs/dist/nesting-********.js` | 1.13 kB | | `docs/dist/react-********.js` | 239 B | | `packages/core/dist/signals-core.js` | 1.48 kB | | `packages/core/dist/signals-core.mjs` | 1.5 kB | | `packages/preact/dist/signals.js` | 1.2 kB | | `packages/preact/dist/signals.mjs` | 1.15 kB | | `packages/react/dist/signals.js` | 1.25 kB | | `packages/react/dist/signals.mjs` | 1.21 kB |

compressed-size-action

rschristian commented 1 year ago

Can do! I should've mentioned this on that PR, but evidently forgot to.