Closed XantreDev closed 1 year ago
Latest commit: 7d5ad6e573f30abb668dd40031592026f2de4baf
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Name | Link |
---|---|
Latest commit | 7d5ad6e573f30abb668dd40031592026f2de4baf |
Latest deploy log | https://app.netlify.com/sites/preact-signals-demo/deploys/64c235500354dc0008344203 |
Deploy Preview | https://deploy-preview-387--preact-signals-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@andrewiggins i think it has no performance overhead in case of rendering string into Text nodes directly, but adds oprtunity to render jsx inside signal.
Researching preact
source code was fun.
There are oprtunity when chaning signal type jsx -> string
, to directly create Text node and replace it in this.base
and this.__v.__e
, but i am not sure will it give real performance boost
I will add changeset
after review
@JoviDeCroock please check this PR πππ
Fixed comments @JoviDeCroock
This also needs a changeset and probably a rebase/merge so the netlify checks start succeeding
@JoviDeCroock please check)
Resolves #https://github.com/preactjs/signals/issues/383
When we return a VNode in a signal/computed we would incorrectly try to treat this as a text-node, which would result in us incorrectly triggering changes