Closed andrewiggins closed 10 months ago
Latest commit: b45b041e4d89f6f952af485e7dc5dd5ec780f602
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | b45b041e4d89f6f952af485e7dc5dd5ec780f602 |
Latest deploy log | https://app.netlify.com/sites/preact-signals-demo/deploys/6531b921718e33000819cdb3 |
Deploy Preview | https://deploy-preview-422--preact-signals-demo.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Size Change: +1.07 kB (+1%)
Total Size: 80.8 kB
Filename | Size | Change | |
---|---|---|---|
docs/dist/assets/client.********.js |
47 kB | +371 B (+1%) | |
docs/dist/nesting-********.js |
1.13 kB | -1 B (0%) | |
docs/dist/react-********.js |
237 B | -1 B (0%) | |
packages/react-transform/dist/signals-*********.js |
3.55 kB | +31 B (+1%) | |
packages/react-transform/dist/signals-transform.mjs |
2.87 kB | +32 B (+1%) | |
packages/react-transform/dist/signals-transform.umd.js |
3.67 kB | +30 B (+1%) | |
packages/react/dist/signals.js |
1.62 kB | +270 B (+20%) | đ¨ |
packages/react/dist/signals.mjs |
1.64 kB | +341 B (+26%) | đ¨ |
Abandoning this for the moment. May revisit later after resolving other issues first
When using the react-transform, components aren't automatically tracked for signal usage. So the SignalValue component isn't reactive to signal changes. This PR manually codes the SignalValue to use
useSignals
to track signal usage regardless of the implementation.Related #412