preactjs / signals

Manage state with style in every framework
https://preactjs.com/blog/introducing-signals/
MIT License
3.76k stars 91 forks source link

Fix rendering signals as text when using react-transform #439

Closed andrewiggins closed 10 months ago

andrewiggins commented 10 months ago

As suggested by @developit, disable useSignals when the auto tracking hook is installed since components can instead rely on that behavior. Also, add useSignals to the SignalValue component to fix it when used with the babel transform

changeset-bot[bot] commented 10 months ago

đŸĻ‹ Changeset detected

Latest commit: edf4fae4f0551ffa057eaf7094e72b858d7f8588

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------- | ----- | | @preact/signals-react-transform | Patch | | @preact/signals-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 10 months ago

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit edf4fae4f0551ffa057eaf7094e72b858d7f8588
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/65545497e484c900082a89ce
Deploy Preview https://deploy-preview-439--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 10 months ago

Size Change: +600 B (+1%)

Total Size: 80.3 kB

Filename Size Change
docs/dist/assets/client.********.js 46.9 kB +235 B (+1%)
docs/dist/react-********.js 239 B +1 B (0%)
packages/react-transform/dist/signals-*********.js 3.49 kB -30 B (-1%)
packages/react-transform/dist/signals-transform.mjs 2.8 kB -33 B (-1%)
packages/react-transform/dist/signals-transform.umd.js 3.61 kB -31 B (-1%)
packages/react/dist/signals.js 1.55 kB +197 B (+15%) ⚠ī¸
packages/react/dist/signals.mjs 1.55 kB +261 B (+20%) 🚨
ℹī¸ View Unchanged | Filename | Size | | :--- | :---: | | `docs/dist/assets/index.********.js` | 833 B | | `docs/dist/assets/jsxRuntime.module.********.js` | 281 B | | `docs/dist/assets/preact.module.********.js` | 4.02 kB | | `docs/dist/assets/signals-core.module.********.js` | 1.46 kB | | `docs/dist/assets/signals.module.********.js` | 2.02 kB | | `docs/dist/assets/style.********.js` | 21 B | | `docs/dist/assets/style.********.css` | 1.21 kB | | `docs/dist/basic-********.js` | 244 B | | `docs/dist/demos-********.js` | 3.35 kB | | `docs/dist/nesting-********.js` | 1.13 kB | | `packages/core/dist/signals-core.js` | 1.54 kB | | `packages/core/dist/signals-core.mjs` | 1.56 kB | | `packages/preact/dist/signals.js` | 1.27 kB | | `packages/preact/dist/signals.mjs` | 1.22 kB |

compressed-size-action