search

preactjs / signals

Manage state with style in every framework
https://preactjs.com/blog/introducing-signals/
MIT License
3.76k stars 91 forks source link

Removes backward-incompatible type export. #451

Closed dcporter closed 10 months ago

dcporter commented 10 months ago

This syntax (export { type Foo }) insta-breaks the build for any project using versions of TS earlier than v4.5. Verified locally that this change fixes the build for earlier versions while not breaking it for later versions.

I believe the only scenario in which this change could impact tree-shaking is if someone is only importing the ReadonlySignal type in a project that doesn't otherwise use signals, which seems unlikely.

changeset-bot[bot] commented 10 months ago

🦋 Changeset detected

Latest commit: 990f1eb36fa4ab5e30029f79ceeccf709137d14d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------- | ----- | | @preact/signals-core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 10 months ago

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit 990f1eb36fa4ab5e30029f79ceeccf709137d14d
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6564ae8a9f46d80008d5f8c2
Deploy Preview https://deploy-preview-451--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dcporter commented 10 months ago

The change was originally made by @eddyw in #231 (a very cool PR otherwise) — wanted to @ Eddy in to make sure I'm not missing any big consequences here.

XantreDev commented 10 months ago

What is a problem to upgrade typescript?