preactjs / signals

Manage state with style in every framework
https://preactjs.com/blog/introducing-signals/
MIT License
3.76k stars 91 forks source link

No component rerendering with @preact/signal-react #453

Closed roo7690 closed 6 months ago

roo7690 commented 10 months ago

Hello, I'm having a problem with @preact/signal-react. Using this code provided by the documentation,

import { useSignal, useComputed, effect } from "@preact/signals-react";

export default function () {
    const count = useSignal(0);
    const double = useComputed(() => count.value * 2);

    effect(()=>{
        console.log(count.value,double.value)
    })

    return (
        <button onClick={() => count.value++}>
            Value: {count.value}, value x 2 = {double.value}
        </button>
    );
}

there is a subscription of the console.log() that re-executes with each change but no rerendering of the component

XantreDev commented 10 months ago

In which environment do you using signals? Webpack? Vite? Next.js?

jesseagleboy commented 10 months ago

Just as speculation from my time working with Preact Signals, the issue could be because the count.value and double.value in your JSX are not being used in the proper way. Any signal or computed value within the JSX should be inserted without explicitly saying .value. Preact Signals handles the rendering behind the scenes. But as @XantreGodlike asked above, I've noticed Vite and Webpack can have different results at times.

rschristian commented 10 months ago

Any signal or computed value within the JSX should be inserted without explicitly saying .value.

Not quite, no. Using .value just opts you out of the direct text node binding, you absolutely can do it though. Just need a full rerender of the component to update.

XantreDev commented 10 months ago

Just as speculation from my time working with Preact Signals, the issue could be because the count.value and double.value in your JSX are not being used in the proper way. Any signal or computed value within the JSX should be inserted without explicitly saying .value. Preact Signals handles the rendering behind the scenes. But as @XantreGodlike asked above, I've noticed Vite and Webpack can have different results at times.

Omitting .value is fully optional performance optimization. It should work any way - it will rerender SignalValue or the parent component

roo7690 commented 10 months ago

@XantreGodlike Oops, I should have mentioned. It's on Nextjs; through this increment, we can see that there is an omission.

"use client"
import { effect, signal } from "@preact/signals-react";

const i=signal(0)
setInterval(()=>i.value++,1000)

effect(()=>{
    console.log(i.value)
})

export default function Page () {

    return i
}
XantreDev commented 10 months ago

@roo7690 use can try my @preact-signals/safe-react with manual subscribing components to signals via HOC. It's not so cool as automatic tracking, but for now I don't know better options for next.js. For now I researching opportunity to migrate babel plugin to swc to make it working with next.js https://github.com/XantreGodlike/preact-signals/issues/43

Dylan-yoon-mp commented 10 months ago

first of all, I appreciate about your work I also facing same problem. I did integrate @preact-signals/safe-react into my React native project it seems can subscribe signals but the component not re-render

in case I declare temporary state and update state from useSignalEffect to force re-render, it's working but I don't think this is working well as intended

XantreDev commented 10 months ago

@Dylan-yoon-mp Did you run yarn start --reset-cache?

Dylan-yoon-mp commented 10 months ago

@XantreGodlike yes many times but i didn't work I want share my env just in case

react-native: 0.71.12 react-navigation: 0.6.x @preact-signals/safe-react: 0.3.1

XantreDev commented 10 months ago

Did you change babel config?

Dylan-yoon-mp commented 10 months ago

yes I did

kerituni12 commented 9 months ago

same issue with "vite": "^4.5.0" and "@preact/signals-react": "^2.0.0"

Loque18 commented 9 months ago

same issue

sellwawy commented 9 months ago

Same issue in Next.js and Vite.

XantreDev commented 9 months ago

@rschristian Should we add Troubleshooting section to readme? I can provide PR

rschristian commented 9 months ago

What would that entail (especially in relation to this issue)?

XantreDev commented 9 months ago

What would that entail (especially in relation to this issue)?

Components don't track signals or Components do not update if signal value changes or Lack of component reactivity

ReevMich commented 9 months ago

For me, the simple vite react typescript template doesnt work with @preact/signal-react 2.0.0 using the .value, but when I switch to 1.3.8 it works as id expect. I have also tried the same thing in a create react app webpack environment. The switch to version 1.38 does resolve the issue. https://stackblitz.com/edit/vitejs-vite-pj3xda?file=package.json,src%2FApp.tsx&terminal=dev

rschristian commented 9 months ago

For me, the simple vite react typescript template doesnt work with @preact/signal-react 2.0.0 using the .value

You haven't followed the v2 usage instructions

ReevMich commented 9 months ago

For me, the simple vite react typescript template doesnt work with @preact/signal-react 2.0.0 using the .value

You haven't followed the v2 usage instructions

Your right, I missed the babel stuff. Thanks.

PivaRos commented 7 months ago

Quick solution:

This is probably because you didn't set the babel config.

Solution 1: Setting the babel config should fix the issue

Solution 2: Adding the hook useSignals() in the top of the file

rschristian commented 6 months ago

Closing as answered.